Add future annotations to prompt_helper for Python 3.9 compat#20850
Open
debu-sinha wants to merge 2 commits intorun-llama:mainfrom
Open
Add future annotations to prompt_helper for Python 3.9 compat#20850debu-sinha wants to merge 2 commits intorun-llama:mainfrom
debu-sinha wants to merge 2 commits intorun-llama:mainfrom
Conversation
ChatPromptHelper uses PEP 604 union syntax (LLM | None) which raises TypeError at runtime on Python 3.9. Adding the future annotations import makes all type hints lazy strings, fixing the 3.9 test suite.
dosubot
bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prompt_helper.py uses
X | Yunion syntax (PEP 604) which requires Python 3.10+. On Python 3.9, this raisesTypeError: unsupported operand type(s) for |: 'type' and 'type'.Adding
from __future__ import annotationsmakes the type hints lazy-evaluated strings, which fixes the issue on Python 3.9.Found this while investigating the CI failure on #20813 where the Python 3.9 test suite was failing on import.